this post was submitted on 02 Nov 2024
115 points (100.0% liked)

Fediverse

28444 readers
898 users here now

A community to talk about the Fediverse and all it's related services using ActivityPub (Mastodon, Lemmy, KBin, etc).

If you wanted to get help with moderating your own community then head over to !moderators@lemmy.world!

Rules

Learn more at these websites: Join The Fediverse Wiki, Fediverse.info, Wikipedia Page, The Federation Info (Stats), FediDB (Stats), Sub Rehab (Reddit Migration), Search Lemmy

founded 1 year ago
MODERATORS
 

Append attachments to comments by flamingo-cant-draw ?? Pull Request #5143 ?? LemmyNet/lemmy

you are viewing a single comment's thread
view the rest of the comments
[–] andrew_s@piefed.social 3 points 2 weeks ago (1 children)

How does Piefed handle image attachments, btw?

For comments: not at all. If a Mastodon user tried to do what I did, with the inline image, nothing would show.

We could do what I think you've done, and regex the details of the attachment into ! [] () Markdown and add it to the text. There's also a DB relationship between comments and images that isn't used, but could be, I suppose.

I've never actually seen a Mastodon user try to add an image to something that ended up as a Lemmy comment, tbh, so it's not something I've thought too much about.

[–] flamingos@feddit.uk 4 points 2 weeks ago* (last edited 2 weeks ago) (1 children)

We could do what I think you’ve done, and regex the details of the attachment into ! [] ()

To be clear, this pull request doesn't use regex, it's just JSON deserialisation and string interpolation.

I’ve never actually seen a Mastodon user try to add an image to something that ended up as a Lemmy comment, tbh, so it’s not something I’ve thought too much about.

The pull request actually includes one, the main KDE account tags !kde@lemmy.kde.social and includes pictures in their threads regularly. It's just hard to tell from our side as you can't see what's missing.

[–] andrew_s@piefed.social 4 points 2 weeks ago

Ah, great, thank you. It's been added as an Issue for PF now, with a link to this post, so that'll be handy.

(I was likely misusing the term 'regex').