But why is hardcoding shit code for open source code? The code is easier to read because no if or switch statements are needed to distinguish between the options. No configiration menu has to be maintained.

[–] fushuan@lemmy.blahaj.zone 4 points 2 days ago

That if chain is horrendous. You should have a config json file with an array of links and then use a for and check for each of them.

The advantage of having a config file is that it's easily for others to see everything that can be changed dynamically without touching the code, and it's much easier to maintain forks that change or extend the configurable behaviour.

Hard coding shit is bad because it's actually harder to maintain. No programmer worth their salt has difficulty checking the json file that has the configuration for X list, hard coding an if chain is bad coding.

[–] notfromhere@lemmy.ml 10 points 4 days ago* (last edited 4 days ago)

Open source just means people are free to edit it and distribute their changes. Hardcoding things like this is bad practice no matter if it’s open source or not. It’s not maintainable. Maintainable as in easily maintainable, I.e., configuration files not code edits.