Fediverse

28566 readers

530 users here now

A community to talk about the Fediverse and all it's related services using ActivityPub (Mastodon, Lemmy, KBin, etc).

If you wanted to get help with moderating your own community then head over to !moderators@lemmy.world!

Rules

Posts must be on topic.
Be respectful of others.
Cite the sources used for graphs and other statistics.
Follow the general Lemmy.world rules.

Learn more at these websites: Join The Fediverse Wiki, Fediverse.info, Wikipedia Page, The Federation Info (Stats), FediDB (Stats), Sub Rehab (Reddit Migration), Search Lemmy

founded 2 years ago

MODERATORS

ruud@lemmy.world

Xylinna@lemmy.world

MrCenny@lemmy.world

TragicNotCute@lemmy.world

automodbeta@lemmy.world

woelkchen@lemmy.world

115

Microblog (think Mastodon)−style attachments support merged into Lemmy (github.com)

submitted 1 month ago by Aatube@kbin.melroy.org to c/fediverse@lemmy.world

17 comments fedilink hide all child comments

Append attachments to comments by flamingo-cant-draw ?? Pull Request #5143 ?? LemmyNet/lemmy

you are viewing a single comment's thread
view the rest of the comments

[–] andrew_s@piefed.social 8 points 1 month ago* (last edited 1 month ago) (1 children)

I just tried with Masto - maybe there's different versions, but it didn't work with the one I tried.

Screenshot:

It's probably for the best that this PR doesn't also convert inline Markdown into an attachment to send out for Mastodon's benefit, because then there would be the danger of apps that understand both showing two images. It'd be better if Mastodon did the translation when receiving stuff, but Mastodon doesn't seem as good as MBIN when it comes to co-operating with Lemmy.

(edit: how that screenshot shows on MBIN is a bit disappointing though - at least looking at on the web)

[–] flamingos@feddit.uk 4 points 1 month ago* (last edited 1 month ago) (1 children)

This is Mastodon's HTML sanitiser, you can see they stipe out <img> tags.

How does Piefed handle image attachments, btw?

[–] andrew_s@piefed.social 3 points 1 month ago (1 children)

How does Piefed handle image attachments, btw?

For comments: not at all. If a Mastodon user tried to do what I did, with the inline image, nothing would show.

We could do what I think you've done, and regex the details of the attachment into ! [] () Markdown and add it to the text. There's also a DB relationship between comments and images that isn't used, but could be, I suppose.

I've never actually seen a Mastodon user try to add an image to something that ended up as a Lemmy comment, tbh, so it's not something I've thought too much about.

[–] flamingos@feddit.uk 4 points 1 month ago* (last edited 1 month ago) (1 children)

We could do what I think you’ve done, and regex the details of the attachment into ! [] ()

To be clear, this pull request doesn't use regex, it's just JSON deserialisation and string interpolation.

I’ve never actually seen a Mastodon user try to add an image to something that ended up as a Lemmy comment, tbh, so it’s not something I’ve thought too much about.

The pull request actually includes one, the main KDE account tags !kde@lemmy.kde.social and includes pictures in their threads regularly. It's just hard to tell from our side as you can't see what's missing.

[–] andrew_s@piefed.social 4 points 1 month ago

Ah, great, thank you. It's been added as an Issue for PF now, with a link to this post, so that'll be handy.

(I was likely misusing the term 'regex').